Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update doc #420

Merged
merged 5 commits into from
Sep 18, 2024
Merged

Update doc #420

merged 5 commits into from
Sep 18, 2024

Conversation

DivadNojnarg
Copy link
Collaborator

@DivadNojnarg DivadNojnarg commented Sep 16, 2024 •
edited
Loading

  • Remove blockr.data from import. This prevents from installing blockr as the remote field is outdated.
  • Update outdated links
  • Improve doc according to @MikeJohnPage's feedback
  • Improve shinylive links management (cc @JohnCoene) Shinylive links #326
  • ...

@DivadNojnarg DivadNojnarg added documentation Improvements or additions to documentation critical labels Sep 16, 2024
@DivadNojnarg DivadNojnarg marked this pull request as ready for review September 17, 2024 14:35
@DivadNojnarg DivadNojnarg requested a review from nbenn as a code owner September 17, 2024 14:35
nbenn
nbenn approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@nbenn nbenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks!

@DivadNojnarg DivadNojnarg merged commit e6549b2 into main Sep 18, 2024
5 checks passed
@DivadNojnarg DivadNojnarg deleted the 419-update-links branch November 18, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbenn nbenn nbenn approved these changes

Assignees
No one assigned
Labels
critical documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DivadNojnarg @nbenn